Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Bazel 7.3.1 and flip --incompatible_use_plus_in_repo_names #23450

Closed
wants to merge 1 commit into from

Conversation

Wyverald
Copy link
Member

This allows us to get rid of some interim hacks.

Also had to add a patch to protobuf to properly quote arguments for the copy command. This usage of copy is no longer there on protobuf main, and our version is pretty old, so no need to upstream anything.

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Aug 27, 2024
@Wyverald
Copy link
Member Author

@bazel-io fork 7.4.0

Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Aug 28, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Aug 29, 2024
@Wyverald Wyverald deleted the wyv-use-730 branch August 30, 2024 00:30
@iancha1992
Copy link
Member

The changes in this PR have been included in Bazel 7.4.0 RC1. Please test out the release candidate and report any issues as soon as possible.
If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=7.4.0rc1. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants